rustfmt librustc_trans/save #28161
rustfmt librustc_trans/save #28161
Conversation
|
r? @Aatch (rust_highfive has picked a reviewer for you, use r? to override) |
|
Addressed bounds issue |
|
☔ The latest upstream changes (presumably #28174) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @brson |
|
Damn good formatting, right here! r=me |
|
Super excited about being able to run |
|
@bors: r=brson |
|
📌 Commit 6a127e9 has been approved by |
|
⌛ Testing commit 6a127e9 with merge b508991... |
|
@bors: retry force |
|
⌛ Testing commit 6a127e9 with merge 779b2a9... |
| @@ -653,8 +647,8 @@ impl <'l, 'tcx> DumpCsvVisitor<'l, 'tcx> { | |||
| } | |||
| } | |||
|
|
|||
| fn process_mod(&mut self, | |||
| item: &ast::Item) { // The module in question, represented as an item. | |||
| // `item` is the module in question, represented as an item. | |||
There was a problem hiding this comment.
@nrc did you notice that it moved the comment from inside to outside of the function? Is this intentional?
There was a problem hiding this comment.
This was actually a manual fixup, so intentional. The comment is on the arg, so it doesn't matter if it is inside or outside the function.
(This is actually due to an interesting bug in rustfmt - we check to see if everything will fit on one line, then deal with 'inner' comments, in this case by appending them, which causes the line to overflow. It's tricky because the only indicator that the comment will start on the same line is the absence of a newline which isn't in anything's span. So I had to patch around the bug for now...).
No description provided.